Exclude files specifically changed for release from rc sync PR #1643
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dime10 , My original motivation was to only exclude the check-catalyst.yaml file, but not too sure about the rest. I am not sure how frequently we would have changes in the other files that want in the main too. Do you think it make sense to exclude them? |
Contributor
|
Hello. You may have forgotten to update the changelog!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1643 +/- ##
=======================================
Coverage 96.57% 96.57%
=======================================
Files 85 85
Lines 9403 9403
Branches 879 879
=======================================
Hits 9081 9081
Misses 262 262
Partials 60 60 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Is this still relavant? |
dime10
reviewed
May 5, 2025
erick-xanadu
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
During feature freeze, we need to modify the
check-catalystworkflow on the release candidate branch. These changes should not be included in the daily sync that merged into main branch.Description of the Change:
check-catalystworkflow which should be modified in feature freeze week to be excluded.Benefits:
Less maintenance of the daily rc sync PR.
Possible Drawbacks:
Related GitHub Issues: